Skip to content

fix: allow Thread#name= to set name #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 20, 2020
Merged

fix: allow Thread#name= to set name #8

merged 1 commit into from
Mar 20, 2020

Conversation

@olleolleolle
Copy link
Contributor

@olleolleolle olleolleolle commented Mar 14, 2020

This PR fixes an ostensible copypasta error: a setter parameter is named and not used.

@coveralls
Copy link

coveralls commented Mar 14, 2020

Coverage Status

Coverage remained the same at 79.173% when pulling c5e7fca on olleolleolle:fix-thread-can-be-named into 45a2f5d on socketry:master.

@olleolleolle olleolleolle requested a review from ioquatix March 20, 2020 16:26
@ioquatix ioquatix merged commit 55f70f8 into socketry:master Mar 20, 2020
@ioquatix
Copy link
Member

ioquatix commented Mar 20, 2020

Thanks!

@olleolleolle olleolleolle deleted the fix-thread-can-be-named branch March 20, 2020 20:29
@ioquatix ioquatix self-assigned this Apr 4, 2020
@ioquatix ioquatix removed their request for review April 4, 2020 13:51
@ioquatix ioquatix added the bug label Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ioquatix ioquatix

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@olleolleolle @coveralls @ioquatix