Skip to content

Conversation

@olleolleolle
Copy link
Contributor

This PR removes explicitly added return statements where they're "implied".

I did this so that all the places "work and look the same". As a guide for the reader.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 79.143% when pulling c70147a on olleolleolle:return-statement-reduced-away into 45a2f5d on socketry:master.

@ioquatix
Copy link
Member

ioquatix commented Jul 9, 2020

I don't like implicit return if there is more than one line of code in a method body. However, if I'm inconsistent, it's probably a mistake. The key point is it needs to be completely unambiguous that 1/ it's a return value and 2/ future modifications to the method can't possibly break the flow control of the method.

@ioquatix ioquatix closed this Jul 9, 2020
@olleolleolle olleolleolle deleted the return-statement-reduced-away branch July 9, 2020 06:09
@olleolleolle
Copy link
Contributor Author

Consistency is more important. Thanks for making a decision! Forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants