Skip to content

Conversation

@janko
Copy link
Contributor

@janko janko commented Jul 7, 2018

This adds specs for Body::Fixed, Body::Chunked, and Body::Buffered, including the specs that assert memory allocations.

I also included two changes to the application code:

  • Body::Buffered#each was removed, as from what I could see it's the same as the inherited Body::Readable#each
  • Body::Buffered#empty? was updated to actually return true when #read would return nil (like the RDocs for Body::Readable#empty? say)

@coveralls
Copy link

coveralls commented Jul 7, 2018

Coverage Status

Coverage increased (+0.5%) to 89.8% when pulling 547ea36 on add-more-body-specs into 9db36bc on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.5%) to 89.8% when pulling 547ea36 on add-more-body-specs into 9db36bc on master.

@ioquatix
Copy link
Member

ioquatix commented Jul 8, 2018

Thanks for your effort making more specs and fixing bugs.

@ioquatix ioquatix merged commit be71292 into master Jul 8, 2018
@ioquatix ioquatix deleted the add-more-body-specs branch July 8, 2018 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants