Skip to content

If a task returns an exception value, do not raise it in #wait. #270

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2023
Merged

If a task returns an exception value, do not raise it in #wait. #270

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/async/task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ def wait
@finished.wait
end

if @result.is_a?(Exception)
if @status == :failed
raise @result
else
return @result
Expand Down
7 changes: 7 additions & 0 deletions test/async/task.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -711,6 +711,13 @@ def sleep_forever
expect(error_task).to be(:finished?)
expect(innocent_task).to be(:finished?)
end

it "will not raise exception values returned by the task" do
error = StandardError.new
task = reactor.async { error }
expect(task.wait).to be == error
expect(task.result).to be == error
end
end

with '#result' do
Expand Down