Skip to content

Guide: ensure url exists in block #278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 13, 2023
Merged

Guide: ensure url exists in block #278

merged 1 commit into from
Sep 13, 2023

Conversation

@eval
Copy link
Contributor

@eval eval commented Sep 12, 2023 •
edited
Loading

Following the guide gave me a runtime error - turns out url is not passed to the block :)

Types of Changes

  • Bug fix.
  • Maintenance.

Contribution

olleolleolle
olleolleolle approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! ✨

@ioquatix ioquatix merged commit caeec3b into socketry:main Sep 13, 2023
@ioquatix
Copy link
Member

ioquatix commented Sep 13, 2023

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

@ioquatix ioquatix ioquatix approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eval @ioquatix @olleolleolle