Skip to content

Fix behavior of Filter#off!/all! #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Fix behavior of Filter#off!/all! #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/console/filter.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,11 +100,11 @@ def verbose!(value = true)
end

def off!
@level = -1
@level = self.class::MAXIMUM_LEVEL + 1
end

def all!
@level = self.class::MAXIMUM_LEVEL
@level = -1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at this, I wonder what I was thinking when I wrote this. Seriously, it looks messed up.

end

# You can enable and disable logging for classes. This function checks if logging for a given subject is enabled.
Expand Down
26 changes: 26 additions & 0 deletions spec/console/logger_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,4 +92,30 @@
subject.debug(object, message)
end
end

describe "#off!" do
before do
subject.off!
end

described_class::LEVELS.each do |name, level|
it "doesn't log #{name} messages" do
expect(output).to_not receive(:call)
subject.send(name, message)
end
end
end

describe "#all!" do
before do
subject.all!
end

described_class::LEVELS.each do |name, level|
it "can log #{name} messages" do
expect(output).to receive(:call).with(message, severity: name)
subject.send(name, message)
end
end
end
end