re-support ruby 2.3 #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
I am okay with this, but do we need more than one PR to make it possible? |
Contributor
Author
|
Could you release new version protocol-http and async-http which uses the new version of protocol-http when you have time. |
Member
|
Sure. |
Member
|
We also need to check |
Contributor
Author
|
these gems seem not to be needed to update. or is there anything I missed? |
Member
|
Need to add 2.3 back to travis e.g. https://github.com/socketry/protocol-http2/blob/master/.travis.yml |
This was referenced Jun 20, 2019
Contributor
Author
|
Thank you for your help. I sent patches! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi. I'm a maintainer of fluentd. fluend began to use async-http in this PR
I'd like protocol-http to re-support ruby 2.3 which is the version fluentd supports yet.
I know that MRI teams had ended the support of ruby 2.3. however, ruby 2.3 is still used by many people, and we have to support this version.
If this gem re-support ruby 2.3, it's very helpful for fluentd.
What do you think of this? @ioquatix