Skip to content

support 2.3 on CI #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

support 2.3 on CI #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7b99f6
support 2.3 on CI
ganmacs Jun 20, 2019
3f598e9
monkey patch gets to match with 2.4 or later get's interface
ganmacs Jun 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ cache: bundler

matrix:
include:
- rvm: 2.3
- rvm: 2.4
- rvm: 2.5
- rvm: 2.6
Expand Down
20 changes: 18 additions & 2 deletions spec/protocol/http1/connection_context.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,24 @@
require 'socket'

RSpec.shared_context Protocol::HTTP1::Connection do
let(:sockets) {Socket.pair(Socket::PF_UNIX, Socket::SOCK_STREAM)}

let(:sockets) {
r, w = Socket.pair(Socket::PF_UNIX, Socket::SOCK_STREAM)
# https://github.com/socketry/protocol-http1/pull/1#discussion_r295598266
# https://docs.ruby-lang.org/en/2.3.0/IO.html#method-i-gets
# https://docs.ruby-lang.org/en/2.5.0/IO.html#method-i-gets
if !($stdin.gets(nil, 0, chomp: true) rescue nil)
def r.gets(*args, chomp: false)
chomp ? super(*args).chomp : super(*args)
end

def w.gets(*args, chomp: false)
chomp ? super(*args).chomp : super(*args)
end
end

[r, w]
}

let(:client) {Protocol::HTTP1::Connection.new(sockets.first)}
let(:server) {Protocol::HTTP1::Connection.new(sockets.last)}
end