Allow empty header values. #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

ioquatix merged 1 commit into socketry:main from samuel-williams-shopify:allow-empty-header-value

Mar 20, 2025

Contributor

samuel-williams-shopify commented Mar 20, 2025 •

edited

Loading

The recent change to the parser prevented empty headers from being sent over the wire by #write_response. Fix this regression and add tests.

Types of Changes

Bug fix.

Contribution

I added tests for my changes.
I tested my changes locally.
I agree to the Developer's Certificate of Origin 1.1.


          Allow empty headers.

735b6f3

ioquatix merged commit bfbbe12 into socketry:main

22 of 24 checks passed

samuel-williams-shopify deleted the allow-empty-header-value branch

March 20, 2025 23:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet