Potential fix for code scanning alert no. 3: Incomplete string escaping or encoding #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for https://github.com/soderlind/wordpress-readme-preview/security/code-scanning/3
To address this problem, we need to ensure that any metacharacters in
token, including the backslash\, are correctly escaped before using it in a dynamically constructed regular expression. The preferred and safest way is to use a general-purpose function to escape all regex metacharacters, not just a specific subset. The npm libraryescape-string-regexpis the canonical solution, but if only standard library usage is allowed, we can write a function to escape all regex metacharacters, including backslash.In file
src/parser/validator.ts, at line 464, replace the inline.replace(/([*~])/g,'\$1')with a function call such asescapeRegExp(token), whereescapeRegExp` escapes all regex metacharacters safely. Add the following function definition somewhere in the file (near the top or above where it's used):Then update the invocation inside
countMatchesto call this helper function. No other lines need adjustment.Suggested fixes powered by Copilot Autofix. Review carefully before merging.