Skip to content

fix: parameter sliders not showing in embedded view when loading from iframe for the first time #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 2, 2025
Merged

fix: parameter sliders not showing in embedded view when loading from iframe for the first time #6

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a21f18
fix: parameter sliders not showing in embedded view when loading from…
schwarzSTE Apr 2, 2025
5344176
Merge remote-tracking branch 'origin/hackathon-2025' into fix/embed-s…
Jsscrdng Apr 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/pages/Index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,6 +161,10 @@ const Index = () => {
const urlFormulas = getFormulasFromUrl();
if (urlFormulas) {
setFormulas(urlFormulas);
// Select the first formula if in embedded mode so parameter controls will show
if (isEmbedded && urlFormulas.length > 0) {
setSelectedFormulaId(urlFormulas[0].id);
}
}

// Get tool from URL
Expand All @@ -180,7 +184,7 @@ const Index = () => {

// Mark that we've loaded from URL
hasLoadedFromUrl.current = true;
}, []);
}, [isEmbedded]);

// Update URL whenever shapes, formulas, grid position, or tool changes
useEffect(() => {
Expand Down