Skip to content

Conversation

@allmightyspiff
Copy link
Member

Added the following commands:

*quote View and Order a quote
*quote-detail View a quote
*quote-list List all active quotes on an account

Updated some of the ordering related docs as well.

@allmightyspiff allmightyspiff self-assigned this Apr 18, 2019
@allmightyspiff allmightyspiff added CLI Ordering Anything related to ordering labels Apr 18, 2019
@coveralls
Copy link

coveralls commented Apr 18, 2019

Coverage Status

Coverage increased (+0.1%) to 92.108% when pulling 683af37 on allmightyspiff:orderingDocUpdates into f350a98 on softlayer:master.

Copy link
Contributor

@acamacho82 acamacho82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice feature, I was testing the slcli order quote and I got the following error with XMLRPC when using --verify option

$ slcli order quote 2472575 --fqdn ajcb.camacho.com --complex-type SoftLayer_Container_Product_Order_Virtual_Guest --verify

SoftLayerAPIError(SoftLayer_Exception_Public): Reserved Capacity #0 not found.

With REST endpoint works fine, so it seems the problem is in the XML structure that is sent to the server

Copy link
Contributor

@ATGE ATGE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks goods

@allmightyspiff
Copy link
Member Author

Looks like the verifyOrder problem was because in XML we pass in '' instead of None, so my fix was to just remove any '' fields from the result we get back from getRecalculatedOrderContainer

Copy link
Contributor

@FernandoOjeda FernandoOjeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good.

@allmightyspiff allmightyspiff merged commit 606ec64 into softlayer:master Apr 23, 2019
@allmightyspiff
Copy link
Member Author

fixes #208

@allmightyspiff allmightyspiff deleted the orderingDocUpdates branch August 31, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLI Ordering Anything related to ordering

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants