Skip to content

Conversation

@ATGE
Copy link
Contributor

@ATGE ATGE commented Oct 10, 2019

No description provided.

@coveralls
Copy link

coveralls commented Oct 10, 2019

Coverage Status

Coverage increased (+0.02%) to 93.828% when pulling 479035f on ATGE:issue1095 into 767dd35 on softlayer:master.

@ATGE ATGE requested review from caberos and removed request for caberos October 10, 2019 22:28
Copy link
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, we just need to catch the NameError exception and this change will be perfect.

@allmightyspiff
Copy link
Member

Fixes #1095

@allmightyspiff allmightyspiff added the Core Issues dealing with core functionality label Oct 10, 2019
@allmightyspiff allmightyspiff merged commit 29c74a8 into softlayer:master Oct 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Core Issues dealing with core functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants