Fix block storage failback and failover. #1200
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@allmightyspiff I ran the tox analysis for the master softlayer python without changing anything and I got the same error that the travis, could you check it please. |
allmightyspiff
requested changes
Dec 19, 2019
Member
allmightyspiff
left a comment
allmightyspiff
left a comment
There was a problem hiding this comment.
The change you have look good, but can you do the same for the file CLI/manager bits. Looks like they have the exact same problem as well.
Member
|
I fixed the flake8 tests in #1201 , trying to rebuild now. |
Member
|
Since i'm going to do a release now, I'm merging this in. Could you fix up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix block storage failback and failover #1199.