Skip to content

Commit 5c4f27a

Browse files
committed
refactor: refactor deps updater
1 parent 637c103 commit 5c4f27a

1 file changed

Lines changed: 22 additions & 19 deletions

File tree

lib/package.js

Lines changed: 22 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -673,10 +673,10 @@ export default class Package {
673673

674674
for ( const dependency of dependencies ) {
675675

676-
// missed dependency
676+
// not-installed dependency
677677
if ( !dependency.location ) {
678678
dependency.location = path.join( this.root, "node_modules", name );
679-
dependency.missed = true;
679+
dependency.notInstalled = true;
680680
}
681681

682682
if ( index[ dependency.location ] ) {
@@ -702,10 +702,10 @@ export default class Package {
702702
}
703703
}
704704

705-
// add missed / linked deps
705+
// add not-installed / linked deps
706706
for ( const dependency of linkedDependencies.values() ) {
707707
if ( index[ dependency.location ] ) {
708-
index[ dependency.location ].missed = dependency.missed;
708+
index[ dependency.location ].notInstalled = dependency.notInstalled;
709709
index[ dependency.location ].linked = dependency.linked;
710710
}
711711
else {
@@ -722,38 +722,41 @@ export default class Package {
722722
// outdated dependency
723723
dependency.outdated = dependency.wanted !== dependency.latest && new SemanticVersion( dependency.latest ).gt( dependency.wanted );
724724

725-
// include installed, updatable deps by default
726725
let include;
727726

728-
// linked
729-
if ( dependency.linked ) {
727+
// not-installed deps
728+
if ( dependency.notInstalled ) {
729+
include = true;
730+
730731
if ( linked ) {
731732
dependency.updatable = true;
733+
}
734+
}
732735

733-
include = true;
736+
// linked
737+
else if ( dependency.linked ) {
738+
include = true;
739+
740+
if ( linked ) {
741+
dependency.updatable = true;
734742
}
735743
}
736744

737745
// not linked
738746
else {
739747
dependency.updatable = dependency.current !== dependency.wanted;
740748

741-
// some peer deps can be optional, so we additionally check dependency.current
749+
// peer deps can be optional, so we additionally check dependency.current
742750
if ( dependency.updatable && dependency.current ) {
743751
include = true;
744752
}
745753
}
746754

747-
// include top-level outdated deps
755+
// top-level outdated deps
748756
if ( outdated && dependency.outdated && dependency.topLevel ) {
749757
include = true;
750758
}
751759

752-
// include missed deps
753-
if ( dependency.missed ) {
754-
include = true;
755-
}
756-
757760
if ( !include ) continue;
758761

759762
// updatable dependency
@@ -836,8 +839,8 @@ export default class Package {
836839
"width": 20,
837840
"format": ( value, row ) => {
838841
if ( !value ) {
839-
if ( row.missed ) {
840-
return ansi.error( " MISSED " );
842+
if ( row.notInstalled ) {
843+
return ansi.error( " NOT INSTALLED " );
841844
}
842845
else if ( row.linked ) {
843846
return ansi.error( " LINKED " );
@@ -1562,12 +1565,12 @@ export default class Package {
15621565
// not a link
15631566
if ( e.code !== "EINVAL" ) {
15641567

1565-
// missed
1568+
// not-installed
15661569
if ( e.code === "ENOENT" ) {
15671570
dependencies.set( name, {
15681571
name,
15691572
location,
1570-
"missed": true,
1573+
"notInstalled": true,
15711574
} );
15721575
}
15731576

0 commit comments

Comments
 (0)