Skip to content

Commit 9cd9d2e

Browse files
committed
refactor: refactor deps updater
1 parent a3ed98e commit 9cd9d2e

1 file changed

Lines changed: 9 additions & 14 deletions

File tree

lib/package.js

Lines changed: 9 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -719,18 +719,18 @@ export default class Package {
719719

720720
// linked
721721
if ( dependency.linked ) {
722-
723-
// XXX
724722
if ( linked ) {
725723
dependency.updatable = true;
726724

727725
include = true;
728726
}
729727
}
728+
729+
// not linked
730730
else {
731731
dependency.updatable = dependency.current !== dependency.wanted;
732732

733-
if ( dependency.updatable && dependency.current ) {
733+
if ( dependency.updatable ) {
734734
include = true;
735735
}
736736
}
@@ -740,11 +740,6 @@ export default class Package {
740740
include = true;
741741
}
742742

743-
// include linked deps
744-
if ( dependency.linked ) {
745-
include = true;
746-
}
747-
748743
// include missed deps
749744
if ( dependency.missed ) {
750745
include = true;
@@ -780,6 +775,11 @@ export default class Package {
780775
"title": ansi.hl( "DEPENDENCY" ),
781776
"headerAlign": "center",
782777
"headerValign": "end",
778+
},
779+
"dependent": {
780+
"title": ansi.hl( "DEPENDENT" ),
781+
"headerAlign": "center",
782+
"headerValign": "end",
783783
format ( value ) {
784784
if ( value ) {
785785
return [ ...value ].sort().join( ", " );
@@ -789,11 +789,6 @@ export default class Package {
789789
}
790790
},
791791
},
792-
"dependent": {
793-
"title": ansi.hl( "DEPENDENT" ),
794-
"headerAlign": "center",
795-
"headerValign": "end",
796-
},
797792
"current": {
798793
"title": ansi.hl( "INSTALLED" ),
799794
"headerAlign": "center",
@@ -832,7 +827,7 @@ export default class Package {
832827
"width": 20,
833828
"format": ( value, row ) => {
834829
if ( !value ) {
835-
if ( row.linked === true ) {
830+
if ( row.missed ) {
836831
return ansi.error( " MISSED " );
837832
}
838833
else if ( row.linked ) {

0 commit comments

Comments
 (0)