fix: reinstall missing and linked deps

Author: zdm

lib/commands/package/update-dependencies.js

@@ -71,7 +71,7 @@ export default class extends Command {
                 },
                 "reinstall-linked": {
                     "short": "r",
-                    "description": "reinstall linked packages",
+                    "description": "reinstall linked or missing dependencies",
                     "default": false,
                     "schema": {
                         "type": "boolean",

lib/commands/workspace/update-dependencies.js

@@ -74,7 +74,7 @@ export default class extends Command {
                 },
                 "reinstall-linked": {
                     "short": "r",
-                    "description": "reinstall linked packages",
+                    "description": "reinstall linked or missing dependencies",
                     "default": false,
                     "schema": {
                         "type": "boolean",

lib/package.js

@@ -46,6 +46,7 @@ export default class Package {
     #localization;
     #rootSlug;
     #parentSlug;
+    #dependencies;
 
     constructor ( root, { rootPackage, parentPackage } = {} ) {
         this.#root = root;
@@ -318,8 +319,21 @@ export default class Package {
         return fs.existsSync( this.root + "/npm-shrinkwrap.json" );
     }
 
+    get dependencies () {
+        if ( !this.#dependencies ) {
+            this.#dependencies = new Map( Object.entries( {
+                ...this.config.dependencies,
+                ...this.config.devDependencies,
+                ...this.config.peerDependencies,
+                ...this.config.optionalDependencies,
+            } ) );
+        }
+
+        return this.#dependencies;
+    }
+
     get hasDependencies () {
-        return Object.keys( this.config.dependencies || {} ).length || Object.keys( this.config.devDependencies || {} ).length || Object.keys( this.config.peerDependencies || {} ).length || Object.keys( this.config.optionalDependencies || {} ).length;
+        return Boolean( this.dependencies.size );
     }
 
     // public
@@ -425,45 +439,38 @@ export default class Package {
     }
 
     hasPreReleaseDependencies () {
-        const config = this.config;
-
-        for ( const name of [ "dependencies", "devDependencies", "peerDependencies", "optionalDependencies" ] ) {
-            if ( !config[ name ] ) continue;
+        for ( const [ name, version ] of this.dependencies.entries() ) {
 
-            for ( const dependencyName in config[ name ] ) {
-                const version = config[ name ][ dependencyName ];
-
-                // process known tags
-                if ( version === "latest" ) {
-                    continue;
-                }
-                else if ( version === "next" ) {
-                    return result( [ 500, `Package "${ this.name }" has pre-release dependency "${ dependencyName }@${ version }"` ] );
-                }
+            // process known tags
+            if ( version === "latest" ) {
+                continue;
+            }
+            else if ( version === "next" ) {
+                return result( [ 500, `Package "${ this.name }" has pre-release dependency "${ name }@${ version }"` ] );
+            }
 
-                let dependencyRange;
+            let dependencyRange;
 
-                // detect git url
-                const match = version.match( /#semver:(.+)$/ );
+            // detect git url
+            const match = version.match( /#semver:(.+)$/ );
 
-                if ( match ) {
-                    dependencyRange = match[ 1 ];
-                }
-                else {
-                    dependencyRange = version;
-                }
+            if ( match ) {
+                dependencyRange = match[ 1 ];
+            }
+            else {
+                dependencyRange = version;
+            }
 
-                dependencyRange = new SemanticVersionRange( dependencyRange );
+            dependencyRange = new SemanticVersionRange( dependencyRange );
 
-                try {
-                    if ( dependencyRange.isPreRelease ) {
-                        return result( [ 500, `Package "${ this.name }" has pre-release dependency "${ dependencyName }@${ version }"` ] );
-                    }
-                }
-                catch {
-                    return result( [ 500, `Unable to parse dependency version "${ dependencyName }@ ${ version }"` ] );
+            try {
+                if ( dependencyRange.isPreRelease ) {
+                    return result( [ 500, `Package "${ this.name }" has pre-release dependency "${ name }@${ version }"` ] );
                 }
             }
+            catch {
+                return result( [ 500, `Unable to parse dependency version "${ name }@ ${ version }"` ] );
+            }
         }
 
         return result( 200 );
@@ -694,7 +701,9 @@ export default class Package {
         var res;
 
         if ( install && reinstallLinked && !reinstall ) {
-            reinstall = await this.#hasLinkedPackages();
+            const missedDependencies = await this.#getMissedDependencies();
+
+            reinstall = Boolean( missedDependencies.size );
         }
 
         // get outdated dependencies
@@ -1195,6 +1204,7 @@ export default class Package {
         this.#version = undefined;
         this.#workspaces = undefined;
         this.#subPackages = undefined;
+        this.#dependencies = undefined;
     }
 
     async #updateMetadata ( { dependabot, commit } = {} ) {
@@ -1467,33 +1477,26 @@ export default class Package {
         );
     }
 
-    async #hasLinkedPackages () {
-        const dirs = await glob(
-            [
-
-                //
-                "*",
-                "@*/*",
-            ],
-            {
-                "cwd": this.root + "/node_modules",
-                "absolute": true,
-                "files": false,
-                "directories": true,
-            }
-        );
+    async #getMissedDependencies () {
+        const dependencies = new Map();
 
-        var hasLinkedPackages = false;
+        await Promise.all( [ ...this.dependencies.keys() ].map( name =>
+            fs.promises
+                .readlink( `${ this.root }/node_modules/${ name }` )
+                .then( link => dependencies.set( name, link ) )
+                .catch( e => {
 
-        await Promise.all( dirs.map( dir => {
-            return fs.promises
-                .readlink( dir )
-                .then( link => {
-                    hasLinkedPackages = true;
-                } )
-                .catch( e => {} );
-        } ) );
+                    // not exists
+                    if ( e.code === "ENOENT" ) {
+                        dependencies.set( name, null );
+                    }
+
+                    // other error
+                    else if ( e.code !== "EINVAL" ) {
+                        console.log( e );
+                    }
+                } ) ) );
 
-        return hasLinkedPackages;
+        return dependencies;
     }
 }