Skip to content

Commit caa6ee0

Browse files
committed
feat: prohibit make stable release with pre-release dependencies
1 parent 802f065 commit caa6ee0

2 files changed

Lines changed: 5 additions & 9 deletions

File tree

lib/package.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ export default class Package {
444444
return result( 200 );
445445
}
446446

447-
hasPreReleaseDependencies () {
447+
checkPreReleaseDependencies () {
448448
for ( const [ name, version ] of this.dependencies.entries() ) {
449449

450450
// process known tags

lib/package/release.js

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -85,16 +85,12 @@ export default class Publish {
8585
// get sub-packages
8686
const subPackages = this.#pkg.subPackages;
8787

88-
// check for pre-released dependencies
89-
if ( !this.#currentRelease.isPreRelease ) {
88+
// check for pre-release dependencies
89+
if ( this.#currentRelease.isStableRelease ) {
9090
for ( const pkg of [ this.#pkg, ...subPackages ] ) {
91-
const res = pkg.hasPreReleaseDependencies();
91+
const res = pkg.checkPreReleaseDependencies();
9292

93-
if ( !res.ok ) {
94-
console.log( ansi.warn( ` WARNING: ` ) + ` One of releasing packages has pre-released dependencies. It is recommended to use pre-release tag.\n` );
95-
96-
continue;
97-
}
93+
if ( !res.ok ) return res;
9894
}
9995
}
10096

0 commit comments

Comments
 (0)