Skip to content

Conversation

@jnccd
Copy link
Member

@jnccd jnccd commented Mar 30, 2023

A participant suggested making the team_enum optional and since it seems to just be a check I agree

@jnccd jnccd requested a review from maxblan March 30, 2023 19:54
@maxblan maxblan changed the base branch from master to fix/perform_move March 30, 2023 20:49
@maxblan maxblan merged commit dc8daf8 into software-challenge:fix/perform_move Mar 30, 2023
@jnccd jnccd deleted the optional-team branch March 30, 2023 22:22
maxblan added a commit that referenced this pull request Mar 31, 2023
* penguins: make team_enum optional (#24)

* Make team_enum optional in possible move functions

* Improve check

* fix(penguin): problem with the current team

* add(starter): check for the current team

* adjust(test): for new pattern

* remove(setup): because of redundancy

* fix(package_builder): problem, which is why he is coping the newly created folder again

* improve(penguin): copy of objects, works now almost twice as fast

* improve(penguin): split up classes into separate files

* add(game client): manually garbage collection after object handling

* fix(test): added imports

Revert "fix(test): added imports"

This reverts commit 133da8f070219497980f756925cb18c9276a6f2b.

fix(test): added imports

* add(test): for game state

---------

Co-authored-by: Dobiko <kobidogao@yahoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants