Skip to content

fix(game state): error that caused the opponent not updating #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

fix(game state): error that caused the opponent not updating #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions socha/api/plugin/penguins/game_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import _pickle as pickle
import logging
from dataclasses import dataclass
from typing import List, Optional

from socha.api.plugin.penguins.board import Board
Expand Down Expand Up @@ -119,12 +120,14 @@ def perform_move(self, move: Move) -> 'GameState':
"""
if self.is_valid_move(move) and self.current_team.name == move.team_enum:
new_board = self.board.move(move)
new_first_team = pickle.loads(pickle.dumps(self.first_team, protocol=-1))
new_second_team = pickle.loads(pickle.dumps(self.second_team, protocol=-1))
new_first_team: Team = pickle.loads(pickle.dumps(self.first_team, protocol=-1))
new_second_team: Team = pickle.loads(pickle.dumps(self.second_team, protocol=-1))
if self.current_team.name == TeamEnum.ONE:
self._update_team(new_first_team, move, new_board)
else:
self._update_team(new_second_team, move, new_board)
new_first_team.opponent = new_second_team
new_second_team.opponent = new_first_team
new_turn = self.turn + 1
new_last_move = move
return GameState(board=new_board, turn=new_turn, first_team=new_first_team, second_team=new_second_team,
Expand Down
2 changes: 1 addition & 1 deletion tests/test_penguins.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ def test_other_team(self):

move = Move(team_enum=TeamEnum.ONE, from_value=None, to_value=CartesianCoordinate(0, 0).to_hex())
new_game_state = self.game_state.perform_move(move)
self.assertEqual(new_game_state.other_team, self.first_team)
self.assertNotEqual(new_game_state.other_team, self.first_team)

move = Move(team_enum=TeamEnum.TWO, from_value=None, to_value=HexCoordinate(2, 2))
new_game_state = new_game_state.perform_move(move)
Expand Down