fix: Fixes in llm after QA #309
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
jakmro
reviewed
May 20, 2025
chmjkb
requested changes
May 21, 2025
chmjkb
reviewed
May 21, 2025
Comment on lines
63
to
66
| **`modelSource`** - `ResourceSource` that specifies the location of the model binary. For more information, take a look at [loading models](../fundamentals/loading-models.md) section. | ||
|
|
||
| **`tokenizerSource`** - URL to the JSON file which contains the tokenizer. | ||
| **`tokenizerSource`** - `ResourceSource` pointing to the JSON file which contains the tokenizer. | ||
|
|
||
| **`tokenizerConfigSource`** - URL to the JSON file which contains the tokenizer config. | ||
| **`tokenizerConfigSource`** - `ResourceSource` pointing to the JSON file which contains the tokenizer config. |
Contributor
There was a problem hiding this comment.
I'm not sure this solves the problem @jakmro mentioned, maybe we should direct here to loading models. In fact we should rename loading models to loading resources, perhaps?
Contributor
Author
There was a problem hiding this comment.
ResourceSourcethat specifies the location of the model binary. For more information, take a look at loading models section.
I direct readers to the details pages here. I think it is enough
| } | ||
|
|
||
| type ResourceSource = string | number; | ||
| type ResourceSource = string | number | object; |
Contributor
Author
There was a problem hiding this comment.
It is object when we use require to load the resource. It's like that all over the code, somebody simply forgot to change it here
chmjkb
approved these changes
May 21, 2025
This PR aims to organize our sidebar in docs by introducing a separation for hooks and TypeScript API. The order of specific subpages will be now configured by editing `sidebars.js`, instead of the default Docusarus way. This PR also changes some styling to make the indentations look prettier. - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] Documentation update (improves or adds clarity to existing documentation) - [ ] iOS - [ ] Android <!-- Provide step-by-step instructions on how to test your changes. Include setup details if necessary. --> <!-- Add screenshots here, if applicable --> <!-- Link related issues here using #issue-number --> - [ ] I have performed a self-review of my code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have updated the documentation accordingly - [ ] My changes generate no new warnings <!-- Include any additional information, assumptions, or context that reviewers might need to understand this PR. --> --------- Co-authored-by: Mateusz Kopciński <mateusz.kopcinski@swmansnion.com>
pweglik
force-pushed
the
@pw/fix-llm-after-qa
branch
from
d81f973 to
42b1c96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes in generate, error handling and docs
Type of change
Tested on
Related issues
#305
Checklist