Skip to content

Conversation

@tomek0123456789
Copy link
Contributor

@tomek0123456789 tomek0123456789 commented Aug 18, 2023

Closes #1149
Closes #1155
Closes #1159

Introduced changes

  • added two methods to GatewayClient - get_public_key and get_signature
  • get_state_update now accepts additional parameter - include_block
  • changed old_root, new_root (BlockStateUpdateSchema) and root (state_root in StarknetBlockSchema) to be Felts

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.49% ⚠️

Comparison is base (aefc710) 96.99% compared to head (c106bd6) 96.51%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1152      +/-   ##
===============================================
- Coverage        96.99%   96.51%   -0.49%     
===============================================
  Files               92       92              
  Lines             4433     4478      +45     
===============================================
+ Hits              4300     4322      +22     
- Misses             133      156      +23     
Files Changed Coverage Δ
starknet_py/net/client_models.py 100.00% <100.00%> (ø)
starknet_py/net/gateway_client.py 96.81% <100.00%> (+0.21%) ⬆️
starknet_py/net/schemas/gateway.py 99.09% <100.00%> (+0.37%) ⬆️
starknet_py/net/signer/test_stark_curve_signer.py 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@drknzz drknzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green checks in tests is what I like 😎 👍
The codecov got hit a bit though, would be good to do something about it before merging

@tomek0123456789 tomek0123456789 merged commit 22eee38 into development Aug 22, 2023
@tomek0123456789 tomek0123456789 deleted the tomek/1149-0.12.2 branch August 22, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove poetry version in checks.yml Remove @pytest.mark.xfail from tests returning NonPrefixedHex (testnet) Starknet v0.12.2 update

3 participants