Skip to content

Conversation

@tomek0123456789
Copy link
Contributor

Closes #1153

Introduced changes

  • KeyPair constructor accepts Hash type
  • KeyPair.from_private_key accepts Hash type

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.21% 🎉

Comparison is base (0243f05) 96.99% compared to head (abede2e) 97.20%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1157      +/-   ##
===============================================
+ Coverage        96.99%   97.20%   +0.21%     
===============================================
  Files               92       92              
  Lines             4419     4433      +14     
===============================================
+ Hits              4286     4309      +23     
+ Misses             133      124       -9     
Files Changed Coverage Δ
starknet_py/net/signer/stark_curve_signer.py 100.00% <100.00%> (ø)
starknet_py/net/signer/test_stark_curve_signer.py 100.00% <100.00%> (ø)

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomek0123456789 tomek0123456789 merged commit aefc710 into development Aug 21, 2023
@tomek0123456789 tomek0123456789 deleted the tomek/1153-key-pair-string-support branch August 21, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change KeyPair.from_private_key argument type from int to Hash

3 participants