Trace API #1175
Merged
Trace API #1175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rknet.py into tomek/981-trace-api
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## development #1175 +/- ##
===============================================
+ Coverage 97.08% 97.51% +0.42%
===============================================
Files 92 92
Lines 4489 4661 +172
===============================================
+ Hits 4358 4545 +187
+ Misses 131 116 -15
☔ View full report in Codecov by Sentry. |
DelevoXDG
reviewed
Sep 7, 2023
Contributor
DelevoXDG
left a comment
DelevoXDG
left a comment
There was a problem hiding this comment.
Nice work! 👍🏻 Added some comments, some of them are subjective, so someone please TAL.
drknzz
reviewed
Sep 8, 2023
DelevoXDG
reviewed
Sep 14, 2023
Contributor
DelevoXDG
left a comment
DelevoXDG
left a comment
There was a problem hiding this comment.
Left few suggestions, otherwise looks good
drknzz
approved these changes
Sep 15, 2023
docs/development.rst
Outdated
| Setup | ||
| ----- | ||
|
|
||
| In order to compile contracts, you need to create ``manifest-path`` file in ``starknet_py/tests/e2e/`` directory and pass the path to Cairo compiler. |
Contributor
There was a problem hiding this comment.
Could we have a message redirecting to the docs about this or directly in the message say about the manifest-path file? I mean to check before the manifest-path is fetched from the file, whether it's even set and if not just throw an error with some information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #981
Introduced changes