Skip to content

Update regex in proxy checks #1187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Update regex in proxy checks #1187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
28ca7f4
change regex to match another node error message
tomek0123456789 Sep 19, 2023
0c1e6e7
Merge branch 'development' into tomek/fix-abi-resolver
tomek0123456789 Sep 20, 2023
69109bf
update migration guide
tomek0123456789 Sep 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/migration_guide.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,13 @@ sets the calldata encoding accordingly.
1. ``cairo_version`` parameter in :meth:`Account.sign_invoke_transaction` and :meth:`Account.execute` has been deprecated.


0.18.2 Bugfixes
---------------

.. currentmodule:: starknet_py.contract

1. Fixed a bug when using ``proxy_config=True`` in :meth:`Contract.from_address` method regarding ``Entry point EntryPointSelector(...) not found in contract``.

0.18.2 Minor changes
--------------------

Expand Down
5 changes: 4 additions & 1 deletion starknet_py/proxy/contract_abi_resolver.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,10 @@ async def _get_implementation_from_proxy(
if implementation is not None:
yield implementation, ImplementationType.ADDRESS
except ClientError as err:
err_msg = r"(Entry point 0x[0-9a-f]+ not found in contract)|(is not declared)|(is not deployed)"
err_msg = (
r"(Entry point ((0x[0-9a-f]+)|(EntryPointSelector\(StarkFelt\(\"0x[0-9a-f]+)\"\)\))"
r" not found in contract)|(is not declared)|(is not deployed)"
)
if not (
re.search(err_msg, err.message, re.IGNORECASE)
or err.code
Expand Down