Skip to content

Conversation

@ddoktorski
Copy link
Collaborator

Closes #1139

Introduced changes

  • Function to get L1 message hash for L1_Handler transactions

Some tests from tests_ci_on_network expected to fail at this point. It should be fixed once #1201 is merged.

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6a63c74) 98.05% compared to head (ab884c8) 98.05%.

Additional details and impacted files
@@             Coverage Diff              @@
##           development    #1205   +/-   ##
============================================
  Coverage        98.05%   98.05%           
============================================
  Files               90       90           
  Lines             4719     4741   +22     
============================================
+ Hits              4627     4649   +22     
  Misses              92       92           
Files Coverage Δ
starknet_py/hash/utils.py 100.00% <100.00%> (ø)
starknet_py/net/client_utils.py 100.00% <100.00%> (ø)
starknet_py/net/full_node_client.py 97.64% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@tomek0123456789 tomek0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just needs adding tests for the utils functions!

@ddoktorski
Copy link
Collaborator Author

Copy link
Contributor

@tomek0123456789 tomek0123456789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@ddoktorski ddoktorski merged commit d35a04a into development Nov 6, 2023
@ddoktorski ddoktorski deleted the ddoktorski/1139-l1-message-hash branch November 6, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add provider function to get L1 message hash (where applicable)

3 participants