-
Notifications
You must be signed in to change notification settings - Fork 90
Add method to get L1 message hash #1205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1205 +/- ##
============================================
Coverage 98.05% 98.05%
============================================
Files 90 90
Lines 4719 4741 +22
============================================
+ Hits 4627 4649 +22
Misses 92 92
☔ View full report in Codecov by Sentry. |
tomek0123456789
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just needs adding tests for the utils functions!
|
Tests for |
tomek0123456789
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, great job!
Closes #1139
Introduced changes
L1_HandlertransactionsSome tests from
tests_ci_on_networkexpected to fail at this point. It should be fixed once #1201 is merged.