Skip to content

Conversation

@ddoktorski
Copy link
Collaborator

Closes #1212

Introduced changes

  • Fix poe test command to run all non-docs tests and print coverage report
  • Remove some poe test tasks that would always fail for some tests
  • Fix omit config for coverage to exclude all test files
  • Move some common pytest options to addopts config

Note: Regarding poe test tasks, this PR is just a small improvement. I think the actual refactoring of test commands should be done after GatewayClient deprecation (#1047).

  • This PR contains breaking changes

@codecov
Copy link

codecov bot commented Nov 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7aaaf3a) 97.47% compared to head (f4fea23) 98.05%.

Additional details and impacted files
@@               Coverage Diff               @@
##           development    #1213      +/-   ##
===============================================
+ Coverage        97.47%   98.05%   +0.57%     
===============================================
  Files               92       90       -2     
  Lines             4749     4719      -30     
===============================================
- Hits              4629     4627       -2     
+ Misses             120       92      -28     

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tomek0123456789 tomek0123456789 merged commit 6a63c74 into development Nov 3, 2023
@tomek0123456789 tomek0123456789 deleted the ddoktorski/1212-codecov-report branch November 3, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Codecov report in checks.yml workflow

3 participants