Remove cairo_version parameter from BaseAccount #1221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #1221 +/- ##
===============================================
- Coverage 98.06% 98.00% -0.07%
===============================================
Files 90 90
Lines 4755 4751 -4
===============================================
- Hits 4663 4656 -7
- Misses 92 95 +3
☔ View full report in Codecov by Sentry. |
Contributor
tomek0123456789
left a comment
tomek0123456789
left a comment
There was a problem hiding this comment.
Great job! 🔥
Needs just info in migration guide about removal of the parameter as a breaking change
tomek0123456789
approved these changes
Nov 10, 2023
tomek0123456789
deleted the
ddoktorski/1184-remove-cairo-version-parameter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1184
Introduced changes
cairo_versionfromBaseAccount.executeandBaseAccount.sign_invoke_transactiontests_on_networksbecause the gateway feeder has been disabled on integration network, it is related to Remove GatewayClient #1047Note: A slight decrease in code coverage is expected.