Skip to content

Conversation

@ddoktorski
Copy link
Collaborator

Closes #1397

Introduced changes

  • Remove insignificant tests
  • Migrate the remaining integration tests to testnet in order to fix the CI

  • This PR contains breaking changes

Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the fact that all integration-related tests should be moved or deleted if they already have an equivalent on the testnet, it looks like these should be removed as well:

  • test_get_chain_id_sepolia_integration
  • integration-related env variables inchecks.yml.
  • client_sepolia_integration, account_sepolia_integration in tests/e2e/tests_on_networks
  • integration-related constants

Also, test-variables.env.template should be updated.

@ddoktorski ddoktorski requested a review from franciszekjob July 17, 2024 11:17
Copy link
Collaborator

@franciszekjob franciszekjob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@ddoktorski ddoktorski merged commit ef4992d into development Jul 17, 2024
@ddoktorski ddoktorski deleted the ddoktorski/1397-integration-tests branch July 17, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate all integration tests to testnet

3 participants