Remove sign_declare_v1 and declare_v1 methods
#1451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…guments.cairo' contracts
…s_when_calldata_not_provided
…eate_deployment_call_raw'
…ts_class_hash' fixture
kkawula
changed the title
Collaborator
franciszekjob
left a comment
franciszekjob
left a comment
There was a problem hiding this comment.
Left one little question, overall looks good 👍
Base automatically changed from
kkawula/replace-cairo-0-contracts-vol4
to
development
August 28, 2024 14:19
Conflicts: starknet_py/abi/v0/parser_test.py starknet_py/abi/v0/schemas_test.py starknet_py/serialization/serialization_test.py starknet_py/tests/e2e/account/account_test.py starknet_py/tests/e2e/block_test.py
franciszekjob
approved these changes
Aug 29, 2024
kkawula
changed the title
sign_declare_v1 and declare_v1 methods
kkawula
added a commit
that referenced
this pull request
Sep 10, 2024
This reverts commit d8b2436. Conflicts: starknet_py/tests/e2e/fixtures/contracts.py Changes to be committed: modified: starknet_py/contract.py modified: starknet_py/net/account/account.py modified: starknet_py/net/account/base_account.py modified: starknet_py/net/client_models.py modified: starknet_py/net/models/__init__.py modified: starknet_py/net/models/transaction.py modified: starknet_py/net/schemas/rpc/transactions.py
kkawula
added a commit
that referenced
this pull request
Sep 10, 2024
* Revert "Remove `sign_declare_v1` and `declare_v1` methods (#1451)" This reverts commit d8b2436. Conflicts: starknet_py/tests/e2e/fixtures/contracts.py Changes to be committed: modified: starknet_py/contract.py modified: starknet_py/net/account/account.py modified: starknet_py/net/account/base_account.py modified: starknet_py/net/client_models.py modified: starknet_py/net/models/__init__.py modified: starknet_py/net/models/transaction.py modified: starknet_py/net/schemas/rpc/transactions.py * Add proper docstring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1334
Introduced changes
Contract.declare_v1Account.sign_declare_v1Declaring contracts made in Cairo 0 is no longer supported
Contract.declare_v1Account.sign_declare_v1