Use previous Ledger app version and re-enable Ledger signer tests #1487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franciszekjob
changed the title
franciszekjob
changed the title
ddoktorski
approved these changes
Sep 11, 2024
Collaborator
ddoktorski
left a comment
ddoktorski
left a comment
There was a problem hiding this comment.
Shouldn't the documentation be updated to mention that the latest starknet app version is not supported?
Collaborator
Author
|
I think it's better if we include information that our interface doesn't allow clear-signing transactions yet, instead it allows to blind-sign. This is more better information for an end-user imo. Wdyt @ddoktorski ? |
Collaborator
Author
|
offline discussion: We will add info about the app's version, as it's visible when installing on Ledger device so it's worth to include it. |
franciszekjob
deleted the
franciszekjob/re-enable-ledger-signer-tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #
Introduced changes
Ledger Starknet app latest version has changed APDU command. It doesn't support e.g. signing deploy account transaction) which is used in our tests. Due to it, we use previous version.
Once future release of Starknet app will support features used in out tests, updating versions and tests should be addressed in #1473.