Skip to content

Conversation

@war-in
Copy link
Contributor

@war-in war-in commented Aug 12, 2022

Please check if the PR fulfills these requirements

  • The formatter, linter, and tests all run without an error
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Closes #301

  • What is the current behavior? (You can also link to an open issue here)

Our tests are using chain id which is deprecated

What is the new behavior (if this is a feature change)?

Deprecation warnings are reduced

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No

Other information

Can't resolve estimate_fee warning on providing max_fee=0. Will work on it

@codecov
Copy link

codecov bot commented Aug 12, 2022

Codecov Report

Merging #305 (537c28b) into development (5d5cdd8) will decrease coverage by 0.20%.
The diff coverage is 100.00%.

@@               Coverage Diff               @@
##           development     #305      +/-   ##
===============================================
- Coverage        96.75%   96.55%   -0.21%     
===============================================
  Files               41       41              
  Lines             1975     1974       -1     
===============================================
- Hits              1911     1906       -5     
- Misses              64       68       +4     
Impacted Files Coverage Δ
starknet_py/contract.py 100.00% <ø> (ø)
starknet_py/net/gateway_schemas/gateway_schemas.py 96.59% <ø> (ø)
starknet_py/net/account/account_client.py 92.90% <100.00%> (ø)
starknet_py/net/full_node_client.py 95.45% <100.00%> (-2.22%) ⬇️
starknet_py/net/gateway_client.py 96.46% <100.00%> (-1.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@war-in war-in marked this pull request as ready for review August 16, 2022 07:17
@war-in war-in requested a review from Arcticae August 16, 2022 08:58
war-in and others added 3 commits August 17, 2022 12:33
Co-authored-by: Tomasz Rejowski <34059895+Arcticae@users.noreply.github.com>
Co-authored-by: Tomasz Rejowski <34059895+Arcticae@users.noreply.github.com>
@war-in war-in requested a review from Arcticae August 17, 2022 10:50
@war-in war-in merged commit 72596d8 into development Aug 17, 2022
@war-in war-in deleted the feat/remove-usage-of-deprecated-features branch August 18, 2022 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove usages of deprecated features through the library

4 participants