-
Notifications
You must be signed in to change notification settings - Fork 90
Remove usage of deprecated features #305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
war-in
merged 13 commits into
development
from
feat/remove-usage-of-deprecated-features
Aug 17, 2022
Merged
Remove usage of deprecated features #305
war-in
merged 13 commits into
development
from
feat/remove-usage-of-deprecated-features
Aug 17, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## development #305 +/- ##
===============================================
- Coverage 96.75% 96.55% -0.21%
===============================================
Files 41 41
Lines 1975 1974 -1
===============================================
- Hits 1911 1906 -5
- Misses 64 68 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Solpatium
reviewed
Aug 12, 2022
Arcticae
requested changes
Aug 17, 2022
Arcticae
requested changes
Aug 17, 2022
Co-authored-by: Tomasz Rejowski <34059895+Arcticae@users.noreply.github.com>
Co-authored-by: Tomasz Rejowski <34059895+Arcticae@users.noreply.github.com>
Arcticae
approved these changes
Aug 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Closes #301
Our tests are using chain id which is deprecated
What is the new behavior (if this is a feature change)?
Deprecation warnings are reduced
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information
Can't resolve estimate_fee warning on providing max_fee=0. Will work on it