forked from NREL/GEOPHIRES-X
-
Notifications
You must be signed in to change notification settings - Fork 1
SAM-EM Multiple Construction Years [v3.10] #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
softwareengineerprogrammer
wants to merge
120
commits into
main
Choose a base branch
from
sam-em-multi-year-construction_v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
SAM-EM Multiple Construction Years [v3.10] #112
softwareengineerprogrammer
wants to merge
120
commits into
main
from
sam-em-multi-year-construction_v3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…WIP to adjust debt service and passed total installed cost to mimick phased capex outlay
…uction years (instead of explicitly specifying value)
…rom construction costs
…terminology (not 'loan')
…minology alignment
…n as being incurred in Year 0 (WIP to likewise adjust accrued financing during construction)
…pre-existing convention - TBD how things shake out when Total CAPEX value is re-aligned to OCC as it was previously...
…ed with pre-existing convention - TBD how things shake out when Total CAPEX value is re-aligned to OCC as it was previously..." This reverts commit cf7bc1b.
…truction convention - WIP: TODO to bump minor version and regenerated affected examples
…nstruction convention
…nterest Rate might be redundant with Inflated Bond Interest Rate
…ated Bond Interest Rate
…or total installed cost and issuance of equity are correct.
…ch wasn't successfully preventing attempted billing)" This reverts commit e4c3faf.
…DC if there are multiple construction years
…ring_construction
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses NREL#406
Approach:
Testing & Verification
TODO:
Bond Financing Start Yearindex off-by-one fix/disambiguationGEOPHIRES/src/geophires_x/EconomicsSam.py
Line 155 in 1095839
_calculate_phased_capex_costsunit test(s)plus:?Done:
Bond Financing Start Year: https://github.com/scientific-web-services/geophires-sws/pull/1/commits/0313a81b4cd9767dda0a20a1066a082d3c256bb9, https://github.com/scientific-web-services/geophires-sws/pull/2/commits/ef9d20c732adf03331da48a7e88d106019188bbfConfirm changes to Accrued financing during construction (backwards-incompatible behavioral change):Removed parameter since it's become ambiguous to the point of being misleading/inaccurate: 00e1b5eChange Checklist:
Observe the following checklist items if your change includes a new version (see versioning notes and version management docs).
Before merging:
After merging:
git push origin refs/tags/vM.m.POriginally self-reviewed in https://github.com/scientific-web-services/geophires-sws/pull/2 and #112