Implement DLQ redrive actions #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt
refactor test
kciesielski
reviewed
Apr 9, 2024
core/src/main/scala/org/elasticmq/actor/queue/operations/MoveMessagesAsyncOps.scala
Show resolved
Hide resolved
kciesielski
reviewed
Apr 9, 2024
kciesielski
reviewed
Apr 9, 2024
...-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/MessageMoveTaskTest.scala
Show resolved
Hide resolved
kciesielski
approved these changes
Apr 9, 2024
mostr
approved these changes
Apr 10, 2024
Contributor
mostr
left a comment
mostr
left a comment
There was a problem hiding this comment.
Few minor comments as I'm quite new to this code
|
|
||
| // then: ensure that not all messages were moved back to the original queue after 2 seconds | ||
| Thread.sleep(2000) | ||
| fetchApproximateNumberOfMessages(queue) should (be > 1 and be < 6) |
Contributor
There was a problem hiding this comment.
Shouldn't that be max 2 and the former one min 4?
Contributor
Author
There was a problem hiding this comment.
Only if the message move jobs starts immediately, which I'm not sure is guaranteed in the environments like the Github Actions provide (fractions of CPU core)
...-sqs-testing-amazon-java-sdk/src/test/scala/org/elasticmq/rest/sqs/MessageMoveTaskTest.scala
Show resolved
Hide resolved
# Conflicts: # rest/rest-sqs/src/main/scala/org/elasticmq/rest/sqs/SQSRestServerBuilder.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #858