Skip to content

Conversation

@henriquemoody
Copy link
Contributor

The script that updates the database tries to execute the tests after
all the data is updated even when the packages are not installed.

This commit will install the packages with Composer when they are not
already installed. It will assume that because you don't have the
"vendor/" directory you probably didn't install the dependencies.

The script that updates the database tries to execute the tests after
all the data is updated even when the packages are not installed.

This commit will install the packages with Composer when they are not
already installed. It will assume that because you don't have the
"vendor/" directory you probably didn't install the dependencies.

Signed-off-by: Henrique Moody <henriquemoody@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.248% when pulling ff2e72a on henriquemoody:composer_install into e786c3b on sokil:master.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.248% when pulling ff2e72a on henriquemoody:composer_install into e786c3b on sokil:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.248% when pulling ff2e72a on henriquemoody:composer_install into e786c3b on sokil:master.

@sokil
Copy link
Owner

sokil commented Apr 2, 2019

This script may be used to update external database on some production environment separately from updating current lib. I think then update process must be also splitted to few processes: for local useage and for production useage. Current script also updates README with new database version, that not required on production. For production composer executes in context of project, not lib.

@henriquemoody
Copy link
Contributor Author

No problem! Thank you for your reply!

@henriquemoody henriquemoody deleted the composer_install branch April 2, 2019 06:36
@sokil
Copy link
Owner

sokil commented Apr 2, 2019

will update this logic soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants