Skip to content

Conversation

@valentinmadrid
Copy link
Collaborator

No description provided.

});

/*
// Comment out because we use init in the transfer instruction
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to include the "create_associated_token_account" instruction then at all?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example reference, yes. The payer's ATA in the tests are also created with this instruction.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the process for creating an ATA for a Token2022 mint different than legacy mints?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nvm, I see where the reference is needed.
Yeah, good with me, leave it in. Just put a little message in your comment header that mentions that you're including this instruction as a reference, but it's not required for the test.
The message you have there isn't super clear at first why it's commented out

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something like "This instruction is included only as a reference, but is not required to run this test, because we are using init in the transfer instruction. The create_associated_token_account instruction on the program is provided as a reference as well"

Copy link
Collaborator Author

@valentinmadrid valentinmadrid Mar 15, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, will make these changes.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made, ready to merge.

@buffalojoec buffalojoec merged commit 8dcf99e into solana-developers:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants