-
Notifications
You must be signed in to change notification settings - Fork 484
🍉 - Add Token 2022 Basics Program #22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| }); | ||
|
|
||
| /* | ||
| // Comment out because we use init in the transfer instruction |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to include the "create_associated_token_account" instruction then at all?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As an example reference, yes. The payer's ATA in the tests are also created with this instruction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the process for creating an ATA for a Token2022 mint different than legacy mints?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nvm, I see where the reference is needed.
Yeah, good with me, leave it in. Just put a little message in your comment header that mentions that you're including this instruction as a reference, but it's not required for the test.
The message you have there isn't super clear at first why it's commented out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like "This instruction is included only as a reference, but is not required to run this test, because we are using init in the transfer instruction. The create_associated_token_account instruction on the program is provided as a reference as well"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good, will make these changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made, ready to merge.
No description provided.