Skip to content

Conversation

@ritikbhatt20
Copy link
Contributor

@ritikbhatt20 ritikbhatt20 commented Oct 27, 2024

Screenshot (572)

Key Difference from other PR's:
- Addition of the latest Poseidon library code, which includes a payer argument for init and initIfNeeded, ensuring compatibility with multi-signer configurations
- previous PR’s had been defaulted to a single signer with only .init() function which will not work with new poseidon code now.

  • added the create-account poseidon program in the /basics/create-account/poseidon directory.
  • replaced all occurrences of yarn with pnpm
  • wrote tests using both Solana Bankrun framework and Anchor native test
  • executed pnpm fix
  • commited pnpm-lock.yaml to the repository

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. create-account basics/create-account labels Nov 15, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@ritikbhatt20
Copy link
Contributor Author

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates

  2. Run pnpm fix at the project root for consistent code style

  3. Ensure your implementation includes:

    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys

  5. Run cargo fmt and cargo clippy for Rust code quality

  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

gm @heyAyushh ,

I've completed the requested steps:

  1. Merged main into my branch.
  2. Ran pnpm fix.
  3. Verified the implementation includes the transpiled Anchor program and TypeScript files.
  4. Synchronized program ID
  5. Ran cargo fmt and cargo clippy for Rust code quality.
  6. Pushed all updates.

Please review again. Thank you!

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribute:poseidon Adds a poseidon example contribution to the repository. create-account basics/create-account

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants