Skip to content

Conversation

@ritikbhatt20
Copy link
Contributor

@ritikbhatt20 ritikbhatt20 commented Oct 27, 2024

Key Differences from previous account-data PRs:

- Addition of the latest Poseidon library code, which includes a payer argument for init and initIfNeeded, ensuring compatibility with multi-signer configurations
- previous PR’s had been defaulted to a single signer with only .init() function which will not work with new poseidon code now.
- Follows the original program structure from the account-data example in Anchor, ensuring consistency.
- Includes both Anchor and Bankrun tests, providing comprehensive test coverage that was missing in previous PRs.
- In some PR's the program structure was not followed and in some bankrun tests weren't there.

  • replaced all occurrences of yarn with pnpm to maintain consistency across the project.
  • executed pnpm fix to ensure code quality.
  • committed the pnpm-lock.yaml file to the repository.

Screenshot (570)

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. account-data basics/account-data labels Nov 18, 2024
@ritikbhatt20
Copy link
Contributor Author

gm @heyAyushh ,

I've completed the requested steps:

  1. Merged main into my branch.
  2. Ran pnpm fix.
  3. Verified the implementation includes the transpiled Anchor program and TypeScript files.
  4. Synchronized program ID
  5. Ran cargo fmt and cargo clippy for Rust code quality.
  6. Pushed all updates.

Please review again. Thank you!

@ritikbhatt20 ritikbhatt20 reopened this Dec 1, 2024
@ritikbhatt20
Copy link
Contributor Author

gm @heyAyushh ,

I have refactored the changes according to new Poseidon Str type..
please review again thanks!

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

account-data basics/account-data contribute:poseidon Adds a poseidon example contribution to the repository.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants