Skip to content

Conversation

@Memewtoo
Copy link
Contributor

@Memewtoo Memewtoo commented Oct 28, 2024

  • Added implementation of counter example for Poseidon framework
  • Follows original anchor program structure for consistency
  • Properly documented Poseidon framework making it easily readable for everyone
  • pnpm package manager support

@heyAyushh heyAyushh added contribute:poseidon Adds a poseidon example contribution to the repository. counter basics/counter labels Nov 15, 2024
Copy link
Member

@heyAyushh heyAyushh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates
  2. Run pnpm fix at the project root for consistent code style
  3. Ensure your implementation includes:
    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys
  5. Run cargo fmt and cargo clippy for Rust code quality
  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

@Memewtoo
Copy link
Contributor Author

Memewtoo commented Nov 25, 2024

Thanks for your submission! To verify the technical implementation, please complete these steps:

  1. Merge the main branch into your PR to get the latest updates

  2. Run pnpm fix at the project root for consistent code style

  3. Ensure your implementation includes:

    • Transpiled Anchor program in the programs folder
    • TypeScript files in the ts-programs folder
  4. Run poseidon sync to synchronize program ID and keys

  5. Run cargo fmt and cargo clippy for Rust code quality

  6. Push your changes

Please note: This review is to verify technical completeness of the submission

Let me know once you've completed these steps and I'll review again. Thanks!

Hi, I've completed the steps for technical implementation, you can see the commit here and the reference of the steps on the image below.

Actually for there's a minor warning on the transcribed solana program by running cargo clippy but I haven't applied the suggested changes as tampering with the transcribed program would defeat the purpose of learning and understanding how to use poseidon properly.

image

@heyAyushh heyAyushh closed this Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

contribute:poseidon Adds a poseidon example contribution to the repository. counter basics/counter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants