Skip to content
This repository was archived by the owner on Jan 24, 2025. It is now read-only.

Conversation

@SAMAD101
Copy link
Contributor

@SAMAD101 SAMAD101 commented Aug 29, 2024

Summary of Changes

  • Updated the Lesson section
  • Updated the PDA section with more elaborative and clear language
  • Updates to the different code snippets
  • updated with the latest version of Anchor
  • added some more explanation to some topics for a better understanding, overall improved the quality of the doc.

@SAMAD101 SAMAD101 requested a review from nickfrosty as a code owner August 29, 2024 13:11
@mikemaccana
Copy link
Contributor

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor changes needed (see above) but nearly done.

@SAMAD101
Copy link
Contributor Author

SAMAD101 commented Aug 30, 2024

Near perfect. A couple of minor bits.

Also please update https://github.com/Unboxed-Software/anchor-movie-review-program to be https://github.com/solana-developers/anchor-movie-review-program and https://github.com/Unboxed-Software/anchor-student-intro-program to https://github.com/solana-developers/anchor-student-intro-program (these repos are already updated)

but those pages are "Not found".
Do I have to update the sources as well ?

It seems that the repos don't exist on solana-developers org

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs the usize change and we're ready to merge.

@SAMAD101
Copy link
Contributor Author

SAMAD101 commented Sep 4, 2024

Just needs the usize change and we're ready to merge.

Done !

Copy link
Contributor

@mikemaccana mikemaccana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but please make the one small change above.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants