-
Notifications
You must be signed in to change notification settings - Fork 7
Core BPF impl: Config #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Re leaving |
Actually I was looking at refactoring config program out of the monorepo altogether, if possible. Wherever not possible, I think we can generate a client here and use just the client to supply I think what might be best is to just move |
I don't think Kinobi generates any of what account-decoder needs for the config program: anza-xyz/agave#265 (comment) So it will just be a matter of cut+paste from
Client seems like the right place to put them! |
You don't need to only rely on generated code for a generated client. There's code you can put client-side only. |
|
Oh sure I just meant that the generated code isn't anything to do with what account-decoder needs |
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Mostly comments on the tests, but the program is perfect.
joncinque
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.

This PR adds the Core BPF implementation of the Config program.
I think in general it makes sense to reduce dependency on the config program crate in the monorepo, so I've omitted the following for now:
create_config_account(helper)impl ConfigState for StakeConfigIf that makes sense I'll look into refactoring over there.
Closes #2