[DRAFT]: add firedancer conformance to ci #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buffalojoec
force-pushed
the
fd-conformance
branch
5 times, most recently
from
6a60769 to
68e98b3
Compare
Contributor
Author
|
@joncinque @lorisleiva this is ready for review! The remaining 6 cases won't pass until I solve what I believe to be a bug in the conformance harness for BPF runs. The implementation in this PR won't change, save for any review feedback. |
lorisleiva
approved these changes
Nov 6, 2024
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Looks great! There's lot of setup required in the script but you've done as good a job as you can IMO.
Contributor
Author
|
We just need these two PRs to land, then this will pass, and can go in! |
joncinque
approved these changes
Nov 8, 2024
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks really cool! Just the one nit from my side, which doesn't need to get updated in this PR
buffalojoec
force-pushed
the
fd-conformance
branch
from
732c037 to
2d7991a
Compare
buffalojoec
force-pushed
the
fd-conformance
branch
from
2d7991a to
3a808a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a job to the program's CI for testing the BPF version against the original builtin version using Firedancer's solana-conformance testing tool. It covers 4496 test cases.