interface: Introduce lightweight crate for instruction + id #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem In order to publish the v3 SDK crates and have them usable in Agave, we also need to have SPL crates using the v3 SDK crates. However, we have a circular dependency between Agave and SPL which currently makes this impossible. The overall plan is to have Agave only use "interface" crates from SPL, which have no dependencies on Agave crates. You can see more info about the project at https://github.com/orgs/anza-xyz/projects/27 Instruction-padding is pretty simple, since it just exposes an instruction creator and id to Agave. #### Summary of changes Create the new interface crate with the instruction and id. The Rust scripts needed to be adapted to having more than one crate, so I copied all the scripts from token-2022 and updated the commands in package.json accordingly.
joncinque
added a commit
to joncinque/instruction-padding
that referenced
this pull request
Jul 31, 2025
#### Problem The repo has no automated publishing workflow. #### Summary of changes Following how it's done at token-2022, add the workflow! This means adding a script, package.json entry, git-cliff configuration, and GH actions workflow file. Note that this requires solana-program#67 to land first.
Merged
buffalojoec
previously approved these changes
Aug 1, 2025
buffalojoec
left a comment
buffalojoec
left a comment
There was a problem hiding this comment.
When updating everything v3 crates, I'll probably also update this to use a Makefile too.
Please do 🙏
scripts/rust/audit.mjs
Outdated
Comment on lines
24
to
33
| // Crate: idna | ||
| // Version: 0.1.5 | ||
| // Title: `idna` accepts Punycode labels that do not produce any non-ASCII when decoded | ||
| // Date: 2024-12-09 | ||
| // ID: RUSTSEC-2024-0421 | ||
| // URL: https://rustsec.org/advisories/RUSTSEC-2024-0421 | ||
| // Solution: Upgrade to >=1.0.0 | ||
| // need to solve this dependency tree: | ||
| // jsonrpc-core-client v18.0.0 -> jsonrpc-client-transports v18.0.0 -> url v1.7.2 -> idna v0.1.5 | ||
| 'RUSTSEC-2024-0421', |
There was a problem hiding this comment.
why is this one only being caught now? It seems old enough to have been caught by previous CI runs.
Contributor
Author
There was a problem hiding this comment.
Oops you're right, thanks for catching that -- I just copied the scripts from another repo
buffalojoec
approved these changes
Aug 1, 2025
joncinque
added a commit
to joncinque/instruction-padding
that referenced
this pull request
Aug 1, 2025
#### Problem The repo has no automated publishing workflow. #### Summary of changes Following how it's done at token-2022, add the workflow! This means adding a script, package.json entry, git-cliff configuration, and GH actions workflow file. Note that this requires solana-program#67 to land first.
joncinque
added a commit
that referenced
this pull request
Aug 2, 2025
* CI: Add publish workflow #### Problem The repo has no automated publishing workflow. #### Summary of changes Following how it's done at token-2022, add the workflow! This means adding a script, package.json entry, git-cliff configuration, and GH actions workflow file. Note that this requires #67 to land first. * Fix yaml * Proper default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
In order to publish the v3 SDK crates and have them usable in Agave, we also need to have SPL crates using the v3 SDK crates. However, we have a circular dependency between Agave and SPL which currently makes this impossible.
The overall plan is to have Agave only use "interface" crates from SPL, which have no dependencies on Agave crates.
You can see more info about the project at https://github.com/orgs/anza-xyz/projects/27
Instruction-padding is pretty simple, since it just exposes an instruction creator and id to Agave.
Summary of changes
Create the new interface crate with the instruction and id.
The Rust scripts needed to be adapted to having more than one crate, so I copied all the scripts from token-2022 and updated the commands in package.json accordingly.
When updating everything v3 crates, I'll probably also update this to use a Makefile too.
Also, I removed the semver-check, and will add that to the publish script when that gets created.