Skip to content

Conversation

@joncinque
Copy link
Contributor

Problem

zx v8 suppresses output from subcommands, as outlined in the migration guide. This makes it challenging to debug issues during CI or local runs.

Summary of changes

Set $.verbose = true via the utils script so that all jobs become verbose.

#### Problem

zx v8 suppresses output from subcommands, as outlined in the migration
[guide](https://google.github.io/zx/migration-from-v7#migration-from-v7-to-v8).
This makes it challenging to debug issues during CI or local runs.

#### Summary of changes

Set `$.verbose = true` via the utils script so that all jobs become
verbose.
@joncinque joncinque requested a review from lorisleiva November 25, 2024 12:19
Copy link
Member

@lorisleiva lorisleiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is okay but maybe it's worth setting it to:

$.verbose = !!process.env.CI

IIRC the hyper-verbosity of v7 used to get quite annoying which is why they disabled it by default on v8.

@joncinque
Copy link
Contributor Author

Maybe I'm misunderstanding something -- why wouldn't we want output for CI? If a test fails in CI, and there's no output, then we won't have any information about the failure

@joncinque
Copy link
Contributor Author

Oh sorry, !! -- then I don't see it on my local runs, right? That kind of defeats the point of this change 😅

@lorisleiva
Copy link
Member

Oh I see, I thought this was only needed for CI. Let's get this merged as-is on this repo and let me know if you're happy with the verbosity across all scripts. We may just need to quiet down some lower-level sub-commands here and there now. I think we can do this on a per-command basis with zx.

@joncinque joncinque enabled auto-merge (squash) November 25, 2024 23:31
@joncinque joncinque disabled auto-merge November 25, 2024 23:31
@joncinque joncinque merged commit 77dd8f7 into solana-program:main Nov 25, 2024
10 checks passed
@joncinque joncinque deleted the verbose branch November 25, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants