CI: Add semver-checks step #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@yihau I've transferred ownership of |
|
accepted! |
lorisleiva
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's easy to accidentally break semver.
Summary of changes
Add a step to CI to run
cargo semver-checks, which will test for any breakage in any PR. We can always override it if needed and bump the version appropriately.More info about the tool at https://github.com/obi1kenobi/cargo-semver-checks
NOTE: it's easiest to have another published version to compare against, so I also bumped
spl-memo-clientto 0.1.0 and published it.For future work, we can also integrate
cargo public-apihttps://github.com/cargo-public-api/cargo-public-api