Skip to content

Conversation

@lorisleiva
Copy link
Member

No description provided.

Copy link
Member

@grod220 grod220 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

export const signAndSendTransaction = async (
client: Client,
transactionMessage: CompilableTransactionMessage &
transactionMessage: BaseTransactionMessage &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used TransactionMessage instead of BaseTransactionMessage. Not sure if the difference matters though.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ir

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's shouldn't matter too much but BaseTransactionMessage is what CompilableTransactionMessage was using under the hood before so I kept the same type for consistency.

@lorisleiva lorisleiva merged commit 6452651 into main Sep 2, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants