deps: Remove decode-error, use program-error's ToStr #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Problem `DecodeError` has been deprecated, so upgrading to the newest crate causes warnings. #### Summary of changes Implement the new `solana_program_error::ToStr` trait and remove some dependencies on the interface. Note that I didn't update the reference implementation program.
joncinque
commented
May 30, 2025
| Eq, | ||
| thiserror::Error, | ||
| num_derive::FromPrimitive, | ||
| num_enum::TryFromPrimitive, |
Contributor
Author
There was a problem hiding this comment.
I'm not sure if we want to generally recommend that people use this instead. Since ToStr requires that the enum implements TryFrom<u32>, this seemed like the easiest option.
If so, we should add that to the help text in the deprecation warning
There was a problem hiding this comment.
Agree, I think is a good idea to provide a recommendation. I wonder if we add something to the docs of the ToStr with an example will be easier to provide more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
DecodeErrorhas been deprecated, so upgrading to the newest crate causes warnings.Summary of changes
Implement the new
solana_program_error::ToStrtrait and remove some dependencies on the interface.Note that I didn't update the reference implementation program.