feat: sd navigation item

[abudd1094]

My first attempt at a Solid PR for ticket:
closes #346

Please help me to adhere to the contribution guidelines and ensure quality stories / testing / organization.

[mariohamann]

On Safari the details' arrow is showing up.

[mariohamann]

Question for @solid-design-system/design

Should it possible that smaller or bigger nav-items have a chevron? Should we change the size of the chevron then?

[mariohamann]

Please remove this kind of stuff from the stories. This is usually only needed when we have multiple kinds of stories in one file, but not for documentation purpose. For documentation you can use the comments above the story.

[mariohamann]

We need stories for relaxed and indented. Please set the element to fixed width then.

[mariohamann]

We only provide default, description and children slot. Please remove the others. (You can create every example by just filling the default slot.)

[van-nguyen-ht]

Hi Mario,
small slot/default - as it's used for level 3 content - there's no nested content for that so I don't think a smaller chevron is needed there
Here's what Ella @EllaELSA commented "Level 3 is smaller text, regular, bold in selected, no description and no icon, no arrow, no badge"

[mariohamann]

mouseenter, mouseleave, click etc. can easily be done on the whole element from users of the element, we don't have to emit that ourself.

Instead I would send events sd-show and sd-hide for the accordion behaviour, as we do for sd-accordion.

[mariohamann]

Please add at least the following props to make it usable as a link:

target, download

See sd-button for imlementation details.

[mariohamann]

Nice! That looks pretty fantastic.

Some small stuff:

• Please use our default focus style for this element. I think it's something like focus-visible:focus-outline or similar.

• Please remote the size part in the variant x size story from the accordion, as this shouldn't be used from a UX perspective (even if it's technically possible).

• Please make a fixed/bigger width for nav items, so it doesn't jump when collapsing.

• We use semantic versioning, so we're just doing a minor bump. Just wait until you finally merge and make a single commit beofre that, which uses e. g. 1.14 or whatever is the next version than.

---

• @coraliefeil Currently the icon-only option is missing – I would like to make this as an improvement within a next ticket, so Alec can can close this one here sooner.

---

• @van-nguyen-ht If you have updated on the "current" line on the left, we would need that now. :)

[mariohamann]

@abudd1094

Sizes should be sm base lg instead of smaller and larger. (Design changed the wording so we can use the same.)

[karlbaumhauer]

pls only bump the minor version.

[coraliefeil]

I’m a bit confused now what to do after I reviewed sth and denied stories ... approve PR or not?

[karlbaumhauer]

I’m a bit confused now what to do after I reviewed sth and denied stories ... approve PR or not?

As you denied 2 stories, the check failed and the PR cannot be merged. As soon as changes have been pushed, you can re-review it and as soon as you approved it, the check will pass and the PR can be merged.

[yoezlem]

@abudd1094 whats the status of this Ticket?

[abudd1094]

@abudd1094 whats the status of this Ticket?

All feedback has been resolved. Ticket is updated and ready for re-review.

[mariohamann]

@solid-design-system/design Could you have a look again? :)