Skip to content

feat: ✨ add sd-table and sd-table-cell#379

Merged
MarcMatthiae merged 22 commits intomainfrom
feat/sd-table
Sep 20, 2023
Merged

feat: ✨ add sd-table and sd-table-cell#379
MarcMatthiae merged 22 commits intomainfrom
feat/sd-table

Conversation

@MarcMatthiae
Copy link
Copy Markdown
Contributor

@MarcMatthiae MarcMatthiae commented Sep 13, 2023 •
edited
Loading

Description:

Add css components sd-table and sd-table-cell.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked
  • PR is assigned to project board

@MarcMatthiae MarcMatthiae linked an issue Sep 13, 2023 that may be closed by this pull request
feat: ✨ add sd-table #18
Closed
6 tasks
@mariohamann
Copy link
Copy Markdown
Contributor

mariohamann commented Sep 14, 2023

CleanShot 2023-09-13 at 12 40 44@2x Please make the background colors an enum, calling it `sd-table-cell--bg-...` to make clear, that this is only for the background. See e. g. CleanShot 2023-09-13 at 12 42 34@2x

I understood, that we provide this as part of the table-cell component and we also wrote that in the story: image

I don´t know if it is necessary, but at least we refined it like that.

Yeah, but we should document it properly. Just provide it as an own style. :)

yoezlem
yoezlem reviewed Sep 14, 2023
View reviewed changes
Comment thread packages/components/src/styles/table-cell/table-cell.css Outdated
yoezlem
yoezlem reviewed Sep 14, 2023
View reviewed changes
Comment thread packages/components/src/styles/table-cell/table-cell.stories.ts Outdated
@MarcMatthiae MarcMatthiae changed the title feat: ✨ add sd-table feat: ✨ add sd-table and sd-table-cell Sep 14, 2023
@MarcMatthiae
Copy link
Copy Markdown
Contributor Author

MarcMatthiae commented Sep 14, 2023

CleanShot 2023-09-13 at 12 40 44@2x Please make the background colors an enum, calling it `sd-table-cell--bg-...` to make clear, that this is only for the background. See e. g. CleanShot 2023-09-13 at 12 42 34@2x

I understood, that we provide this as part of the table-cell component and we also wrote that in the story: image
I don´t know if it is necessary, but at least we refined it like that.

Yeah, but we should document it properly. Just provide it as an own style. :)

Done :)

@coraliefeil coraliefeil removed their request for review September 14, 2023 14:56
@coraliefeil
Copy link
Copy Markdown
Contributor

coraliefeil commented Sep 14, 2023

Review done

@MarcMatthiae
Copy link
Copy Markdown
Contributor Author

MarcMatthiae commented Sep 18, 2023 •
edited
Loading

Main changes

  • Added sd-table
  • Removed "Sortable Table" sample
  • Added "Simple Table" sample
  • Added correct font color to sd-table-cell
  • @coraliefeil Leider brauchen wir diese "default"-Farbe immer, haben wir am Freitag im Daily besprochen. Ich habe jetzt zumindest eingebaut, dass die Farbe in Storybook erstmal auf transparent spring, aber es gibt immer diesen (Default)-Eintrag.

mariohamann
mariohamann reviewed Sep 19, 2023
View reviewed changes
Comment thread packages/components/src/styles/table-cell/table-cell.css Outdated
Comment thread packages/components/src/styles/table-cell/table-cell.declaration.ts Outdated
@EllaELSA
Copy link
Copy Markdown

EllaELSA commented Sep 20, 2023

Review done. Fine for me

@karlbaumhauer karlbaumhauer removed their assignment Sep 20, 2023
@MarcMatthiae MarcMatthiae merged commit ef7c5a9 into main Sep 20, 2023
@MarcMatthiae MarcMatthiae deleted the feat/sd-table branch September 20, 2023 10:36
karlbaumhauer pushed a commit that referenced this pull request Sep 20, 2023
@semantic-release-bot
chore(release/components): 1.13.0 [skip actions]
415b62b 
# [@solid-design-system/components-v1.13.0](components/1.12.0...components/1.13.0) (2023-09-20)

### Features

* ✨ add sd-table and sd-table-cell ([#379](#379)) ([ef7c5a9](ef7c5a9))
yoezlem pushed a commit that referenced this pull request Oct 9, 2023
@MarcMatthiae @yoezlem
feat: ✨ add sd-table and sd-table-cell (#379)
a193fcd 
## Description:
Add css components sd-table and sd-table-cell.

## Definition of Reviewable:
- [x] Documentation is created/updated
- [x] Migration Guide is created/updated
- [x] Stories (features, a11y) are created/updated
- [x] relevant tickets are linked
- [x] PR is assigned to project board
yoezlem pushed a commit that referenced this pull request Oct 9, 2023
@semantic-release-bot @yoezlem
chore(release/components): 1.13.0 [skip actions]
60649c4 
# [@solid-design-system/components-v1.13.0](components/1.12.0...components/1.13.0) (2023-09-20)

### Features

* ✨ add sd-table and sd-table-cell ([#379](#379)) ([ef7c5a9](ef7c5a9))
@yoezlem yoezlem added Development needs changes in code CL-Migration All components which need to be migrated from Component Library labels Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mariohamann mariohamann mariohamann left review comments

@yoezlem yoezlem yoezlem left review comments

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@azraefendic azraefendic Awaiting requested review from azraefendic

@abudd1094 abudd1094 Awaiting requested review from abudd1094

@Vahid1919 Vahid1919 Awaiting requested review from Vahid1919

Assignees

@MarcMatthiae MarcMatthiae

@azraefendic azraefendic

@mariohamann mariohamann

@abudd1094 abudd1094

@coraliefeil coraliefeil

@Vahid1919 Vahid1919

@yoezlem yoezlem

@van-nguyen-ht van-nguyen-ht

Labels

CL-Migration All components which need to be migrated from Component Library Development needs changes in code

Projects

Solid Design System Project Board
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: ✨ add sd-table

10 participants

@MarcMatthiae @mariohamann @coraliefeil @EllaELSA @karlbaumhauer @yoezlem @azraefendic @abudd1094 @Vahid1919 @van-nguyen-ht