Conversation
|
If we implement it like your proposal that would be a pattern. And therefore it shouldn't have any API with different styles, even no controls in Storybook etc. and should just be called |
|
I approved the PR ... Though in the default the quote text color needs to be changed to #181818. I assume for sd-paragraph the font size fix is done separately? Thanks <3 |
|
@coraliefeil Thanks, I changed to color for the default quote. And yes, we will fix the font-size for sd-paragraph in a seperate Ticket: issue-406 (#406) |
yoezlem
requested review from
MarcMatthiae,
Vahid1919,
azraefendic and
karlbaumhauer
| const information = (hidden = false, text = '4xl') => (hidden ? '' : html`<p class="mt-4 text-sm">${text}</p>`); | ||
|
|
||
| /** | ||
| * Default: This shows quote in its default state. |
There was a problem hiding this comment.
The description should be changed to something describing more the use of patterns (IMO). From what I understand there is no "versions" or "states" in patterns right?
There was a problem hiding this comment.
You are right.
Maybe it make also sense to add in our global documentation an explanation for what patterns are (and how to use it).
And inside a pattern I can give a more handy description for the different cases.
What do you guys thing about that?
There was a problem hiding this comment.
Sounds great! Some days ago we discussed the difference between samples and patterns and it feels like this could be the right moment to write that finally down.
I could take that over today!
yoezlem
requested review from
karlbaumhauer and
mariohamann
and removed request for
MarcMatthiae,
karlbaumhauer and
mariohamann
# [@solid-design-system/components-v1.14.0](components/1.13.1...components/1.14.0) (2023-09-21) ### Features * ✨ quote pattern ([#405](#405)) ([f8bc6d8](f8bc6d8))
Author: yoezlem <oezlem.yigit@union-investment.de> Co-authored-by: mariohamann <mario.hamann@virtual-identity.com>
# [@solid-design-system/components-v1.14.0](components/1.13.1...components/1.14.0) (2023-09-21) ### Features * ✨ quote pattern ([#405](#405)) ([f8bc6d8](f8bc6d8))
yoezlem
added
Development
6 participants
This component is currently a draft. We want to take a look at it together and assess whether it makes sense to create sd-quote as a sample or not.
Edit: Not anymore. So feel free to review it ;)